-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lld/mac: Implement support for linker optimization hints (.loh) #50399
Comments
I'm working on this. |
current ld64.lld loh status:
If I remember correctly, @BertalanD said that the implemented ones hit the majority of instances in Chromium Framework (@BertalanD, do you have a histogram at hand?). |
|
|
@BertalanD is there anything left to do here? |
We are still missing |
Extended Description
LLVM supports
.loh
directives (llvm/trunk/test/MC/AArch64/arm64-directive_loh.s). Per https://reviews.llvm.org/D49929:"""
The hints are there so that the linker can turn (non-adjacent) ADRP/ADD sequences, and similar, into ADR/NOP if the referenced symbol ends up close enough; this saves a cycle or so on Apple CPUs. To do that the compiler marks instruction-pairs used to generate a single address and saves that data off in a special MachO load command. I suppose it is sort of a souped-up relocation which specifies two addresses to be relocated instead of just one.
"""
I think we don't support that yet in lld.
The text was updated successfully, but these errors were encountered: