Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

14.0.2: lit module version has not been updated #55137

Closed
kloczek opened this issue Apr 27, 2022 · 10 comments
Closed

14.0.2: lit module version has not been updated #55137

kloczek opened this issue Apr 27, 2022 · 10 comments
Assignees

Comments

@kloczek
Copy link

kloczek commented Apr 27, 2022

__versioninfo__ = (14, 0, 1)
__version__ = '.'.join(str(v) for v in __versioninfo__) + 'dev'

Also it woud be good to drop that dev suffix in stable release.

@DoDoENT
Copy link
Contributor

DoDoENT commented Apr 27, 2022

clang also reports version 14.0.1 (I've just built it from source)...

@DoDoENT
Copy link
Contributor

DoDoENT commented Apr 27, 2022

Basically, everything still reports v14.0.1, as the version hasn't been updated in CMake

@tstellar tstellar self-assigned this Apr 27, 2022
@kloczek
Copy link
Author

kloczek commented Apr 27, 2022

Probably it would be good to take all those places under kind hood of release script which will be injecting all proper values across whole tree before final commit and than tag 😄

@DoDoENT
Copy link
Contributor

DoDoENT commented Apr 27, 2022

At least everything is link-compatible with binaries produced by the real 14.0.1 version, even when using libc++ with unstable ABI (we are utilizing the reported version to inform Conan about binary compatibility so it can decide whether dependencies need to be rebuilt or not).

@tstellar
Copy link
Collaborator

We can't go back and fix this, unfortunately, but here is a patch to prevent the problem in the future: https://reviews.llvm.org/D124539

@zufuliu
Copy link

zufuliu commented Apr 27, 2022

Inside https://github.com/llvm/llvm-project/releases/download/llvmorg-14.0.2/LLVM-14.0.2-win64.exe
both 14.0.1 and 14.0.2 exists under lib\clang\ folder, the former contains more headers but less folders.

D:.
├─14.0.1
│  └─include
│      ├─cuda_wrappers
│      ├─openmp_wrappers
│      └─ppc_wrappers
└─14.0.2
    ├─include
    │  ├─fuzzer
    │  ├─profile
    │  ├─sanitizer
    │  └─xray
    ├─lib
    │  └─windows
    └─share

@DoDoENT
Copy link
Contributor

DoDoENT commented Apr 28, 2022

We can't go back and fix this...

How about making a 14.0.3 release with a fix 😛 ?

@nickdesaulniers
Copy link
Member

How about making a 14.0.3 release with a fix 😛 ?

https://discourse.llvm.org/t/llvm-14-0-3-release/62133

@kloczek
Copy link
Author

kloczek commented Apr 29, 2022

Thank you 😃

@tbaederr
Copy link
Contributor

tbaederr commented Jun 2, 2022

@tstellar I guess this can be closed?

@tstellar tstellar closed this as completed Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants