Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc][math][c23] Implement C23 floating point min and max functions #85496

Closed
lntue opened this issue Mar 16, 2024 · 8 comments
Closed

[libc][math][c23] Implement C23 floating point min and max functions #85496

lntue opened this issue Mar 16, 2024 · 8 comments
Assignees
Labels
c23 good first issue https://github.com/llvm/llvm-project/contribute libc

Comments

@lntue
Copy link
Contributor

lntue commented Mar 16, 2024

  • The missing functions are: fmaximum, fminimum, fmaximum_mag, fminimum_mag, fmaximum_num, fminimum_num, fmaximum_mag_num, fminimum_mag_num.
  • These functions are defined in C23 standard: sections 7.12.12.4 - 7.12.12.11 in https://www.open-std.org/jtc1/sc22/wg14/www/docs/n3096.pdf
  • Need to support the following data types: float, double, long double, float128.
@lntue lntue added good first issue https://github.com/llvm/llvm-project/contribute c23 libc labels Mar 16, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented Mar 16, 2024

@llvm/issue-subscribers-libc

Author: None (lntue)

- The missing functions are: `fmaximum`, `fminimum`, `fmaximum_mag`, `fminimum_mag`, `fmaximum_num`, `fminimum_num`, `fmaximum_mag_num`, `fminimum_mag_num`. - These functions are defined in C23 standard: sections 7.12.12.4 - 7.12.12.11 in https://www.open-std.org/jtc1/sc22/wg14/www/docs/n3096.pdf - Need to support the following data types: float, double, long double, float128.

@llvmbot
Copy link
Collaborator

llvmbot commented Mar 16, 2024

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

  1. In the comments of the issue, request for it to be assigned to you.
  2. Fix the issue locally.
  3. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
  4. Create a Git commit.
  5. Run git clang-format HEAD~1 to format your changes.
  6. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation.

If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.

@llvmbot
Copy link
Collaborator

llvmbot commented Mar 16, 2024

@llvm/issue-subscribers-good-first-issue

Author: None (lntue)

- The missing functions are: `fmaximum`, `fminimum`, `fmaximum_mag`, `fminimum_mag`, `fmaximum_num`, `fminimum_num`, `fmaximum_mag_num`, `fminimum_mag_num`. - These functions are defined in C23 standard: sections 7.12.12.4 - 7.12.12.11 in https://www.open-std.org/jtc1/sc22/wg14/www/docs/n3096.pdf - Need to support the following data types: float, double, long double, float128.

@Jobhdez
Copy link
Member

Jobhdez commented Mar 16, 2024

can this issue be assigned to me please? thanks

@Jobhdez
Copy link
Member

Jobhdez commented Mar 17, 2024

@lntue thanks. I started working on it today.

@deeptirajora
Copy link

please assign this issue to me ?

@Jobhdez
Copy link
Member

Jobhdez commented Mar 18, 2024

please assign this issue to me ?

Hey this has been assigned to me already. I’m working on it right now.

@Jobhdez
Copy link
Member

Jobhdez commented Mar 19, 2024

@lntue hello, hope all is well. I just want to let you know that I’m about to make the tests for my changes. I have written the library functions. I just need to test my code and then I’ll submit my pr. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c23 good first issue https://github.com/llvm/llvm-project/contribute libc
Projects
None yet
Development

No branches or pull requests

4 participants