Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc] [docs] Broken links related to 'libc/config/linux/riscv64' #90316

Closed
jchzhou opened this issue Apr 27, 2024 · 6 comments
Closed

[libc] [docs] Broken links related to 'libc/config/linux/riscv64' #90316

jchzhou opened this issue Apr 27, 2024 · 6 comments

Comments

@jchzhou
Copy link

jchzhou commented Apr 27, 2024

A simple issue:
Link 1 and 2 are pointing to libc/config/linux/riscv64 which in the path is libc/config/linux/riscv instead.

  1. - `linux-riscv64 <https://github.com/llvm/llvm-project/tree/main/libc/config/linux/riscv64/entrypoints.txt>`_
  2. - `linux-riscv64 <https://github.com/llvm/llvm-project/tree/main/libc/config/linux/riscv64/entrypoints.txt>`_

Question: Considering riscv32 exists, should we:

  1. use the 'riscv' folder for both riscv{32,64} codes?
  2. rename riscv to riscv64?
  3. continue to denote riscv64 with riscv and clarify it somewhere?
@michaelrj-google
Copy link
Contributor

right now we're using the riscv folder for both riscv32 and riscv64, so these should just be changed to riscv

@nickdesaulniers nickdesaulniers added the good first issue https://github.com/llvm/llvm-project/contribute label Oct 15, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented Oct 15, 2024

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

  1. Check that no other contributor has already been assigned to this issue. If you believe that no one is actually working on it despite an assignment, ping the person. After one week without a response, the assignee may be changed.
  2. In the comments of this issue, request for it to be assigned to you, or just create a pull request after following the steps below. Mention this issue in the description of the pull request.
  3. Fix the issue locally.
  4. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
  5. Create a Git commit.
  6. Run git clang-format HEAD~1 to format your changes.
  7. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation. Mention this issue in the description of the pull request.

If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.

@llvmbot
Copy link
Collaborator

llvmbot commented Oct 15, 2024

@llvm/issue-subscribers-good-first-issue

Author: jchzhou (jchzhou)

A simple issue: Link [1](https://github.com/llvm/llvm-project/blob/9145514fde484916971e6bb147c18f9235a9f2b5/libc/docs/date_and_time.rst?plain=1#L25) and [2](https://github.com/llvm/llvm-project/blob/9145514fde484916971e6bb147c18f9235a9f2b5/libc/docs/math/index.rst?plain=1#L80) are pointing to `libc/config/linux/riscv64` which in the path is `libc/config/linux/riscv` instead.
  1. - `linux-riscv64 <https://github.com/llvm/llvm-project/tree/main/libc/config/linux/riscv64/entrypoints.txt>`_
  2. - `linux-riscv64 <https://github.com/llvm/llvm-project/tree/main/libc/config/linux/riscv64/entrypoints.txt>`_

Question: Considering riscv32 exists, should we:

  1. use the 'riscv' folder for both riscv{32,64} codes?
  2. rename riscv to riscv64?
  3. continue to denote riscv64 with riscv and clarify it somewhere?

@justinchang91
Copy link

Hi! I would like to work on this issue :)

@justinchang91
Copy link

Looks like this issue has been solved already in this commit by @mikhailramalho.

Are we good to close this issue?

cc: @nickdesaulniers

@nickdesaulniers
Copy link
Member

Yes, good catch! Thanks for finding the relevant commit that addressed this!

@nickdesaulniers nickdesaulniers removed the good first issue https://github.com/llvm/llvm-project/contribute label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants