-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libc] [docs] Broken links related to 'libc/config/linux/riscv64' #90316
Comments
right now we're using the |
Hi! This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:
If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below. |
@llvm/issue-subscribers-good-first-issue Author: jchzhou (jchzhou)
A simple issue:
Link [1](https://github.com/llvm/llvm-project/blob/9145514fde484916971e6bb147c18f9235a9f2b5/libc/docs/date_and_time.rst?plain=1#L25) and [2](https://github.com/llvm/llvm-project/blob/9145514fde484916971e6bb147c18f9235a9f2b5/libc/docs/math/index.rst?plain=1#L80) are pointing to `libc/config/linux/riscv64` which in the path is `libc/config/linux/riscv` instead.
Question: Considering riscv32 exists, should we:
|
Hi! I would like to work on this issue :) |
Looks like this issue has been solved already in this commit by @mikhailramalho. Are we good to close this issue? cc: @nickdesaulniers |
Yes, good catch! Thanks for finding the relevant commit that addressed this! |
A simple issue:
Link 1 and 2 are pointing to
libc/config/linux/riscv64
which in the path islibc/config/linux/riscv
instead.llvm-project/libc/docs/date_and_time.rst
Line 25 in 9145514
llvm-project/libc/docs/math/index.rst
Line 80 in 9145514
Question: Considering riscv32 exists, should we:
riscv
toriscv64
?riscv64
withriscv
and clarify it somewhere?The text was updated successfully, but these errors were encountered: