Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc] proxy header for threads.h #92968

Open
nickdesaulniers opened this issue May 21, 2024 · 3 comments
Open

[libc] proxy header for threads.h #92968

nickdesaulniers opened this issue May 21, 2024 · 3 comments
Assignees
Labels

Comments

@nickdesaulniers
Copy link
Member

#89329 (comment)

@nickdesaulniers nickdesaulniers self-assigned this May 21, 2024
@github-actions github-actions bot added the libc label May 21, 2024
@nickdesaulniers
Copy link
Member Author

To flush out this issue description more, we'd like to:

  1. create libc/hdr/types/cnd_t.h which based on LIBC_FULL_BUILD either
  • includes include/llvm-libc-types/cnd_t.h OR
  • includes <threads.h>
  1. create libc/hdr/threads_macros.h which based on LIBC_FULL_BUILD either
  • defines thrd_error and thrd_success OR
  • includes <threads.h>
  1. replace #include <threads.h> throughout libc/src/ with more specific includes of either libc/hdr/threads_macros.h, or libc/hdr/types/cnd_t.h or other threads related headers (following the same pattern).
  2. clean up the TODO left in src/threads/linux/cnd_broadcast.cpp

@lkartik2212
Copy link

@nickdesaulniers is there any good-first-issue for me that is available for this open issue?

@nickdesaulniers
Copy link
Member Author

Hi @lkartik2212 we would love your help on this issue. I'll reassign it to you. Please reach out if you have questions, get stuck, or no longer plan to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants