Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MachineSink] Reduce the number of unnecessary invalidations of StoreInstrCache (NFC) #68676

Merged
merged 1 commit into from
Oct 12, 2023
Merged

[MachineSink] Reduce the number of unnecessary invalidations of StoreInstrCache (NFC) #68676

merged 1 commit into from
Oct 12, 2023

Conversation

momchil-velikov
Copy link
Collaborator

@momchil-velikov momchil-velikov commented Oct 10, 2023 •
edited
Loading

Don't invalidate the cache when erasing instructions which cannot ever appear in the cache.

momchil-velikov referenced this pull request Oct 10, 2023
@momchil-velikov
Re-apply "[AArch64] Enable "sink-and-fold" in MachineSink by default (#…
a9d0ab2 
…67432)"

This re-applies commit ace20e2, which was reverted in eff4ef2.

The issues were fixed in:

  * b30765c [AArch64] Fix an incorrect handling of debug values in
    MachineSink (#68107)

  * b454b04 [AArch64] Fix a compiler crash in MachineSink (#67705)
@momchil-velikov momchil-velikov merged commit 2ceabf6 into llvm:main Oct 12, 2023
3 checks passed
@momchil-velikov momchil-velikov deleted the machine-sink-store-cache branch October 13, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aemerson aemerson aemerson approved these changes

@davemgreen davemgreen Awaiting requested review from davemgreen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@momchil-velikov @aemerson