[lldb][NFC] Fix compilation issue on windows

[gmh5225]

No description provided.

[github-actions]

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

[llvmbot]

@llvm/pr-subscribers-lldb

Author: gmh (gmh5225)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/76453.diff

1 Files Affected:

• (modified) lldb/source/Plugins/Process/Windows/Common/TargetThreadWindows.cpp (+2-2)

diff --git a/lldb/source/Plugins/Process/Windows/Common/TargetThreadWindows.cpp b/lldb/source/Plugins/Process/Windows/Common/TargetThreadWindows.cpp
index ad67e764fe10f2..a69c10081ff190 100644
--- a/lldb/source/Plugins/Process/Windows/Common/TargetThreadWindows.cpp
+++ b/lldb/source/Plugins/Process/Windows/Common/TargetThreadWindows.cpp
@@ -29,8 +29,8 @@
 using namespace lldb;
 using namespace lldb_private;
 
-using GetThreadDescriptionFunctionPtr = HRESULT
-WINAPI (*)(HANDLE hThread, PWSTR *ppszThreadDescription);
+using GetThreadDescriptionFunctionPtr =
+    HRESULT(WINAPI *)(HANDLE hThread, PWSTR *ppszThreadDescription);
 
 TargetThreadWindows::TargetThreadWindows(ProcessWindows &process,
                                          const HostThread &thread)

[DavidSpickett]

Our Windows bot actually uses clang-cl, I assume msvc is checking the calling convention here.

Going by https://learn.microsoft.com/en-us/cpp/cpp/stdcall?view=msvc-170, it should be stdcall and WINAPI is just stdcall (https://learn.microsoft.com/en-us/office/client-developer/excel/developing-dlls?redirectedfrom=MSDN#exporting-functions-and-commands).

[DavidSpickett]

Please update lldb/unittests/Thread/ThreadTest.cpp as well.

[gmh5225]

Please update lldb/unittests/Thread/ThreadTest.cpp as well.

Thanks for your correction.