Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libcxx] Require qemu-system-arm for armv7m builder #77067

Merged
merged 1 commit into from Jan 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion libcxx/cmake/caches/Armv7M-picolibc.cmake
Expand Up @@ -39,4 +39,4 @@ set(LIBUNWIND_ENABLE_THREADS OFF CACHE BOOL "")
set(LIBUNWIND_IS_BAREMETAL ON CACHE BOOL "")
set(LIBUNWIND_REMEMBER_HEAP_ALLOC ON CACHE BOOL "")
set(LIBUNWIND_USE_COMPILER_RT ON CACHE BOOL "")
find_program(QEMU_SYSTEM_ARM qemu-system-arm)
find_program(QEMU_SYSTEM_ARM qemu-system-arm REQUIRED)
6 changes: 6 additions & 0 deletions libcxx/utils/qemu_baremetal.py
Expand Up @@ -16,6 +16,7 @@
import argparse
import os
import sys
import shutil


def main():
Expand All @@ -32,8 +33,13 @@ def main():
parser.add_argument("test_binary")
parser.add_argument("test_args", nargs=argparse.ZERO_OR_MORE, default=[])
args = parser.parse_args()

if not shutil.which(args.qemu):
sys.exit(f"Failed to find QEMU binary from --qemu value: '{args.qemu}'")

if not os.path.exists(args.test_binary):
sys.exit(f"Expected argument to be a test executable: '{args.test_binary}'")

qemu_commandline = [
args.qemu,
"-chardev",
Expand Down