Add metadata schema to root signature #12
Conversation
This commit adds a metadata schema to the root signature. This schema is used to describe the root signature in llvm IR.
|
|
||
| | RootFlag | Parameters | StaticSamplers | | ||
| |----------|-------------------------------------------------|-------------------------| | ||
| | int | list of RootDescriptor/RootConstant/DescriptorTable | list of StaticSamplers | |
There was a problem hiding this comment.
This doesn't match the example. I think really it should be a list of parameters, and each parameter could be a RootDescriptor, RootConstant, DescriptorTable or StaticSampler. I don't think there's any requirement for the static samplers to come after the other parameters - the grammar doesn't enforce that, so I'm not sure why we would need to add that extra requirement to the metadata format?
There was a problem hiding this comment.
Updated the example.
The list will be null if no static samplers.
There was a problem hiding this comment.
I don't understand why these two lists are separated out. They're not separate in the grammar, so why are we introducing that here?
If this is to match the d3d12 struct definitions, I don't think that's a goal here.
There was a problem hiding this comment.
It started from 2 different list in the string version of root signature.
And will end to 2 different list in the final serialized root signature.
It will be strange to merge them into one list and split later.
There was a problem hiding this comment.
Note also that in the example StaticSampler starts with a parameter type, "StaticSampler", precisely so that it can be intermingled with the other parameters.
There was a problem hiding this comment.
My mistake, I though Static Sampler have to be at end of the root signature which is not true.
If we want to keep things in the same order of the string version of root signature.
Then make a one list make sense.
| Example for same root signature as above: | ||
|
|
||
| ```llvm | ||
| ; placeholder - update this once detailed design complete | ||
| !directx.rootsignatures = !{!2} | ||
| !2 = !{ptr @main, !3 } | ||
| !3 = !{ !4, !5, !6, !7 } ; reference 4 root parameters | ||
| !4 = !{ !"RootFlags", i32 1 } ; root flags, 1 is numeric value of flags | ||
| !5 = !{ !"RootCBV", i32 0, i32 1, i32 0, i32 0 } ; register 0, space 1, 0 = visiblity, 0 = flags | ||
| !6 = !{ !"StaticSampler", i32 1, i32 0, ... } ; register 1, space 0, (additional params omitted) | ||
| !7 = !{ !"DescriptorTable", i32 0, !8, !9 } ; 0 = visibility, 2 ranges,!8 and !9 | ||
| !8 = !{ !"SRV", i32 0, i32 0, i32 -1, i32 0 } ; register 0, space 0, unbounded, flags 0 | ||
| !9 = !{ !"UAV", i32 5, i32 1, i32 10, i32 0 } ; register 5, space 1, 10 descriptors, flags 0 | ||
| ``` |
There was a problem hiding this comment.
This example should stay here since it's part of proposed solutions.
There was a problem hiding this comment.
It looks like this section is still in the detailed design part rather than the proposed solution.
| Example for same root signature as above: | ||
|
|
||
| ```llvm | ||
| ; placeholder - update this once detailed design complete | ||
| !directx.rootsignatures = !{!2} | ||
| !2 = !{ptr @main, !3 } | ||
| !3 = !{ !4, !5, !6, !7 } ; reference 4 root parameters | ||
| !4 = !{ !"RootFlags", i32 1 } ; root flags, 1 is numeric value of flags | ||
| !5 = !{ !"RootCBV", i32 0, i32 1, i32 0, i32 0 } ; register 0, space 1, 0 = visiblity, 0 = flags | ||
| !6 = !{ !"StaticSampler", i32 1, i32 0, ... } ; register 1, space 0, (additional params omitted) | ||
| !7 = !{ !"DescriptorTable", i32 0, !8, !9 } ; 0 = visibility, 2 ranges,!8 and !9 | ||
| !8 = !{ !"SRV", i32 0, i32 0, i32 -1, i32 0 } ; register 0, space 0, unbounded, flags 0 | ||
| !9 = !{ !"UAV", i32 5, i32 1, i32 10, i32 0 } ; register 5, space 1, 10 descriptors, flags 0 | ||
| ``` |
There was a problem hiding this comment.
It looks like this section is still in the detailed design part rather than the proposed solution.
|
|
||
| | Property | Type | Type detail | | ||
| | ---------------- | ----- | -------------------------- | | ||
| | Filter | i32 | D3D12_FILTER | |
There was a problem hiding this comment.
This needs a ParameterType / string / "StaticSampler" row.
|
|
||
| | Property | Type | Type detail | | ||
| | -------------- | ----------------- | --------------------------------------------------- | | ||
| | Root elements | reference to list | list of D3D12_ROOT_SIGNATURE_FLAG/RootDescriptor/RootConstant/DescriptorTable/StaticSamplers | |
There was a problem hiding this comment.
| | Root elements | reference to list | list of D3D12_ROOT_SIGNATURE_FLAG/RootDescriptor/RootConstant/DescriptorTable/StaticSamplers | | |
| | Root elements | reference to list | list of root elements| |
This commit adds a metadata schema to the root signature.
This schema is used to describe the root signature in llvm IR.