Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metadata schema to root signature #12

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add metadata schema to root signature #12

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e26d9c4
Add metadata schema to root signature
python3kgae Aug 5, 2024
a7a5e59
Update per comment.
python3kgae Aug 14, 2024
0af84e8
Update per comment.
python3kgae Sep 5, 2024
a7ed69f
Update per comment.
python3kgae Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions proposals/0002-root-signature-in-clang.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,9 +554,7 @@ The additional semantic rules not already covered by the grammar are listed here

| Property | Type | Type detail |
| -------------- | ----------------- | --------------------------------------------------- |
| RootFlag | i32 | D3D12_ROOT_SIGNATURE_FLAG |
| Parameters | reference to list | list of RootDescriptor/RootConstant/DescriptorTable |
| StaticSamplers | reference to list | list of StaticSamplers |
| Parameters | reference to list | list of D3D12_ROOT_SIGNATURE_FLAG/RootDescriptor/RootConstant/DescriptorTable/StaticSamplers |
damyanp marked this conversation as resolved.
Show resolved Hide resolved

* Function RootSignature pair

Expand All @@ -579,15 +577,12 @@ Example for same root signature as above:
; placeholder - update this once detailed design complete
!dx.rootsignatures = !{!2}
!2 = !{ptr @main, !3 }
!3 = !{ i32 1, !4, !10 } ; RootFlags, Parameters, StaticSamplers
!4 = !{!5, !6} ; list of RootDescriptor/RootConstant/DescriptorTable
!5 = !{ !"RootCBV", i32 0, i32 1, i32 0, i32 0 } ; register 0, space 1, 0 = visiblity, 0 = flags
!6 = !{ !"DescriptorTable", i32 0, !7 } ; 0 = visibility, range list !7
!7 = !{ !8, !9} ; reference 2 descriptor ranges
!8 = !{ !"SRV", i32 0, i32 0, i32 -1, i32 0 } ; register 0, space 0, unbounded, flags 0
!9 = !{ !"UAV", i32 5, i32 1, i32 10, i32 0 } ; register 5, space 1, 10 descriptors, flags 0
!10 = !{!11} ; list of StaticSamplers
!11 = !{ !"StaticSampler", i32 1, i32 0, ... } ; register 1, space 0, (additional params omitted)
!3 = !{ i32 1, !4, !5, !6, !7, !8 } ; RootFlags, Parameters, StaticSamplers
!4 = !{ !"RootCBV", i32 0, i32 1, i32 0, i32 0 } ; register 0, space 1, 0 = visiblity, 0 = flags
!5 = !{ !"DescriptorTable", i32 0, !7 } ; 0 = visibility, range list !7
!6 = !{ !"SRV", i32 0, i32 0, i32 -1, i32 0 } ; register 0, space 0, unbounded, flags 0
!7 = !{ !"UAV", i32 5, i32 1, i32 10, i32 0 } ; register 5, space 1, 10 descriptors, flags 0
!8 = !{ !"StaticSampler", i32 1, i32 0, ... } ; register 1, space 0, (additional params omitted)
```

### Validations during DXIL generation
Expand Down