NA + simulate + re.form = NULL (GH #737) [run ci]

lme4 · Nov 7, 2023 · 1e678b6 · 1e678b6 · mmaechler · Nov 13, 2023
1 parent ce9bd2d
commit 1e678b6
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,5 +1,5 @@
 Package: lme4
-Version: 1.1-35.1
+Version: 1.1-35.1.9000
 Title: Linear Mixed-Effects Models using 'Eigen' and S4
 Authors@R: c(
     person("Douglas","Bates", role="aut",

diff --git a/R/predict.R b/R/predict.R
@@ -502,6 +502,9 @@ predict.merMod <- function(object, newdata=NULL, newparams=NULL,
             newRE <- mkNewReTrms(object, rfd, re.form, na.action=na.action,
                                  allow.new.levels=allow.new.levels)
             REvals <- base::drop(as(newRE$b %*% newRE$Zt, "matrix"))
+            if (class(fit.na.action) %in% c("omit", "exclude") && length(fit.na.action)>0) {
+                REvals <- REvals[-fit.na.action]
+            }
             pred <- pred + REvals
             if (random.only) {
                 fit.na.action <- attr(newRE$Zt,"na.action")

diff --git a/tests/testthat/test-predict.R b/tests/testthat/test-predict.R
@@ -471,3 +471,13 @@ test_that("prediction standard error", {
   expect_equal(p7, p9)  
 
 })
+
+test_that("NA + re.form = NULL + simulate OK", {
+    d <- lme4::sleepstudy
+    d$Reaction[1] <- NA
+    fm1 <- lmer(Reaction ~ Days + (Days | Subject), d)
+    expect_equal(c(head(simulate(fm1, seed = 101, re.form = NULL)[[1]])),
+                 c(266.139101412856, 308.148180398426,
+                   296.081377893883, 338.367909016478, 
+                   360.294339946214, 401.91050930589))
+})