Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try not to import the internal/cpp package if possible #42

Closed
lni opened this issue Apr 4, 2019 · 1 comment
Closed

Try not to import the internal/cpp package if possible #42

lni opened this issue Apr 4, 2019 · 1 comment
Assignees
@lni
Labels
enhancement New feature or request

Comments

@lni
Copy link
Owner

lni commented Apr 4, 2019

It is currently used in drummer tests and by the binding package. In a normal build, try not to import the internal/cpp package.

Once internal/cpp is avoided in a normal build, together with the EXPERIMENTAL pebble support, we should be able to build dragonboat as pure Go project.
@lni lni added the enhancement New feature or request label Apr 4, 2019
@lni lni self-assigned this Apr 4, 2019
@lni lni added need information more information is needed and removed need information more information is needed labels Apr 4, 2019
@lni
Copy link
Owner Author

lni commented Apr 4, 2019

Implemented in v2.1.4.

@lni lni closed this as completed Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lni lni

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lni