Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUDS-06 what is the definition of number? #224

Open
pieterjm opened this issue Jul 10, 2023 · 2 comments
Open

LUDS-06 what is the definition of number? #224

pieterjm opened this issue Jul 10, 2023 · 2 comments

Comments

@pieterjm
Copy link

pieterjm commented Jul 10, 2023

What is the exact specification of number in LUDS-06? A number can be an integer or floating point number.

@hsjoberg
Copy link
Collaborator

hsjoberg commented Jul 10, 2023

The data types in LUDs adhere to the primitive data types of Typescript. #137

The comment for each field in LUD-06 is giving additional context

{
    "callback": string, // The URL from LN SERVICE which will accept the pay request parameters
    "maxSendable": number, // Max millisatoshi amount LN SERVICE is willing to receive
    "minSendable": number, // Min millisatoshi amount LN SERVICE is willing to receive, can not be less than 1 or more than `maxSendable`
    "metadata": string, // Metadata json which must be presented as raw string here, this is required to pass signature verification at a later step
    "tag": "payRequest" // Type of LNURL
}

Millisatoshi should have any decimals, as that makes no sense. An integer should be expected.

What seperators are accepted?

None. That's not allowed in JSON.

@pieterjm
Copy link
Author

Then I think it would be better to change 'number' into 'integer'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants