rebase upstream #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It pointing to mksyscal_windows.go in local folder which already removed
Windows: Set DTS via setCommState
This is due to improvements on the cgo builder related to darwin OS.
This is due to improvements in CGO compiler for darwin OS
This should allow darwin to be compatible with all the latest go1.7.x go1.8.x go1.9.x
Fix 'darwin' build with latest releases of golang
Fix osx build (again...)
Updated to 2020 even if we are less than one month ahead.
This has been observed in particular on MacOS, in this case just retry the call without throwing the error back to the user. Related to: arduino/arduino-cli#504 arduino/arduino-pro-ide#157
confusingly, in this prototype Microsoft decided to split bufSize and reqSize
in retrievePortDetailsFromDevInfo: - updated call to setupDiGetDeviceRegistryProperty with the same style used elsewhere (first get the reqSize, then call) - use of generic variable names, in case the function is extended to fetch other values than spdrpFriendlyName (or spdrpDeviceDesc) - re-enabled the assignment of details.Product
un-commented Product member of the struct PortDetails. This goes with the pull request "completed retrievePortDetailsFromDevInfo #40". Apologies for not submitting together...
The -D option tells it to print something just before starting the transfer phase, which should be enough to ensure that all the file links are available without having to guess a suitable timeout.
Co-authored-by: Cristian Maglie <c.maglie@bug.st>
Co-authored-by: Cristian Maglie <c.maglie@bug.st>
Support arm64 which is used by the new lineup of computers from apple. Signed-off-by: Tobias Kohlbau <tobias@kohlbau.de>
Replace old mkwinsyscall call by the new version which is recommended by Go since version 1.13.3.
Seems like, starting from 10.11, IOUSBDevice has been renamed to IOUSBHostDevice.
Added support for macosx 10.11+
Refresh run of go generate with the latest mksyscall
Windows improve usb serial number discovery
This commit fix regression test TestConcurrentReadAndWrite. Even if the test checks purpose is another it has detected anyway that the returned error is incorrect. Another specific test for closing port detection will be added in the future.
See https://stackoverflow.com/a/34945814/1655275 > pselect signals that file descriptor is ready and > ioctl(fd, FIONREAD, &len) returns zero len. Failure to detect this condition has been revealed by the testsuite: === RUN TestDisconnectingPortDetection 2017/07/27 13:56:37 PR - Connecting to Probe 2017/07/27 13:56:37 > Searching for port 2341:8037 2017/07/27 13:56:37 Detected port '/dev/ttyACM0' 2341:8037 2017/07/27 13:56:37 Using '/dev/ttyACM0' 2017/07/27 13:56:37 Starting test (timeout 20s) 2017/07/27 13:56:37 PR - Turn ON target 2017/07/27 13:56:37 TR - Connecting to Target 2017/07/27 13:56:37 > Searching for port 2341:8036 2017/07/27 13:56:37 Detected port '/dev/ttyACM0' 2341:8037 [...cut...] 2017/07/27 13:56:46 > Searching for port 2341:8036 2017/07/27 13:56:46 Detected port '/dev/ttyACM0' 2341:8037 2017/07/27 13:56:46 Detected port '/dev/ttyACM1' 2341:8036 2017/07/27 13:56:46 Using '/dev/ttyACM1' 2017/07/27 13:56:46 T2 - Make a Read call 2017/07/27 13:56:46 T1 - Delay 200ms before disconnecting target 2017/07/27 13:56:46 T1 - Disconnect target 2017/07/27 13:56:46 PR - Turn OFF target 2017/07/27 13:56:46 T2 - Read returned: n=0 err=nil --- FAIL: TestDisconnectingPortDetection (9.18s) Error Trace: serial_test.go:100 Error: An error is expected but got nil. %s Messages: Read returned no errors this commit fix the problem above.
Implementation of read timeouts
Co-authored-by: Jan-Philipp Benecke <github@bnck.me>
Allow to set non-standard baud rates
Fixed build for linux/ppc64le
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.