Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: Set DTS via setCommState #36

Merged
merged 2 commits into from
Jul 28, 2017
Merged

Windows: Set DTS via setCommState #36

merged 2 commits into from
Jul 28, 2017

Conversation

niondir
Copy link
Contributor

@niondir niondir commented Jul 25, 2017

#35

@cmaglie
Copy link
Member

cmaglie commented Jul 26, 2017

Hi @niondir
I've reproduced the bug and tested that your fix works, thank you!

May I ask you to put the GetDTR() and GetRTS() methods into another PR?
I'd like to have those methods as part of GetModemStatusBits(), but better to move the discussion on another PR, so I can merge the SetRTS bugfix in the meantime.

@cmaglie cmaglie added the bug label Jul 26, 2017
@niondir
Copy link
Contributor Author

niondir commented Jul 28, 2017

Here we go, I will provide another request to extend the GetModemStatusBits() method for windows

@niondir niondir mentioned this pull request Jul 28, 2017
Open
@cmaglie cmaglie merged commit eae1344 into bugst:v1 Jul 28, 2017
@cmaglie cmaglie mentioned this pull request Jul 28, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niondir @cmaglie