3.0.0-alpha3 #290
Merged
3.0.0-alpha3 #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing dev on a channel that doesn't use content facet, but taxonomy facets instead, and keep getting reminded this field isn't actually compulsory. So figured rather than unticking it every time I reinstall I should make a PR :)
…tional Make facets on a channel optional, as is documented from #281.
|
Merge Monday discussion: we should probably fix the deprecated code issues. |
|
I've started fixing things on #294 |
…ition Re-run core update for our blocks added after the fact.
|
Still one failing test. Fails because the It exists as a hidden field on my local, but is missing in the test. Been bashing my head against it, but no luck so far |
|
Note: we already have an alpha2, this might want to be alpha3 |
(a) the new 're-use existing field' form doesn't suffer the JS switch of form that create field does. So the entity types don't appear on that form when they still do for create. (b) the new form settings field has a toggle for enabling a default value.
|
I've just pushed the fix for the test fails into e9dbc2e can be cherry picked to here if we want to get this one out first. |
This reverts commit 7ca5237.
Feature/3.x/geo entity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update module dependencies for D10.