Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localstack.Client.Extensions awsoptions argument null exception #35

Closed
christopher-taormina-zocdoc opened this issue Sep 20, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@christopher-taormina-zocdoc
Copy link

christopher-taormina-zocdoc commented Sep 20, 2023

I recently tried upgrading the client.extensions package from 1.2.0 -> 1.2.1 and suddenly started getting argument null exceptions during dependency injection of the aws service when UseLocalStack is false. It looks like this exception was added in the latest release, but I cannot tell what the reasoning for this breaking change was.

Our code does not make use of the AWS config section in our code and instead relies on the credential chain to either load local profiles or iam roles when deployed. As such we do not pass in AWSOptions with calls to AddAWSServiceLocalStack

diff link

Expected Behavior

The requested aws service should be returned if the aws options object is null.

Actual Behavior

ArgumentNullException is thrown.

Steps to Reproduce the Problem

  1. Use AddServiceLocalStack<T> without explicitly passing in AWSOptions
  2. ArgumentNullException should be throw when resolving T.

Specifications

  • Version: Localstack.Client.Extensions 1.2.1
@Blind-Striker Blind-Striker self-assigned this Sep 21, 2023
@Blind-Striker Blind-Striker added potential bug Something may not be working investigation Further information is requested labels Sep 21, 2023
@Blind-Striker
Copy link
Contributor

Blind-Striker commented Sep 21, 2023

Hi @christopher-taormina-zocdoc ,

Thanks for the issue; I'll start investigating. And if you could provide a code example, it would be very helpful

@Blind-Striker Blind-Striker added bug Something isn't working and removed potential bug Something may not be working labels Sep 21, 2023
@Blind-Striker
Copy link
Contributor

I found the issue and will publish a new release today. Thank you

@Blind-Striker Blind-Striker removed the investigation Further information is requested label Sep 21, 2023
@Blind-Striker
Copy link
Contributor

Hey @christopher-taormina-zocdoc I have released the new version LocalStack.Client.Extentions;

https://www.nuget.org/packages/LocalStack.Client.Extensions/1.2.2

Could you confirm the bug is fixed when you have time?

@christopher-taormina-zocdoc
Copy link
Author

@Blind-Striker Sorry for not responding earlier, but I pulled the latest version and everything looks good. Thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants