You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Using the annotation @LocalstackDockerProperties we should be able to set "pullNewImage" to false - indeed it should be false by default.
However, I have found running this on Windows always attempts to pull a new image, regardless of the setting.
I believe this is due to the check for whether the image exists within cloud.localstack.docker.Container line 71 checks if the list of images contains the image name but does not account for Windows line endings within the ListImagesCommand.execute() method as the list is split on \n only, leaving a \r at the end of the name which is not on the expected fullImageName.
I only noticed this was the expected behaviour when I was trying to work around this issue and noticed that the option didn't work!
Thanks for reporting @jmaes12345 - this should be fixed in #65 . We have just released a new version 0.2.13 to Maven Central. Please let us know if the problem persists. Thanks!
Using the annotation
@LocalstackDockerProperties
we should be able to set "pullNewImage" to false - indeed it should be false by default.However, I have found running this on Windows always attempts to pull a new image, regardless of the setting.
I believe this is due to the check for whether the image exists within
cloud.localstack.docker.Container
line 71 checks if the list of images contains the image name but does not account for Windows line endings within theListImagesCommand.execute()
method as the list is split on\n
only, leaving a\r
at the end of the name which is not on the expectedfullImageName
.I only noticed this was the expected behaviour when I was trying to work around this issue and noticed that the option didn't work!
Steps to reproduce:
Expected:
The log message below is not produced:
Actual:
It is.
The text was updated successfully, but these errors were encountered: