-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] Add util script for building/pushing Docker images #10276
Conversation
LocalStack Community integration with Pro 2 files ± 0 2 suites ±0 1h 26m 46s ⏱️ + 2m 15s Results for commit 0c4b4b3. ± Comparison against base commit 6880b98. This pull request removes 1 and adds 13 tests. Note that renamed tests count towards both.
|
FYI: This PR has been superseded by #10872 (which was based on these changes). |
Motivation
A common use case we're seeing is to build multi-arch Docker images with semantic versioning (build tags like
:3
,3.1
,latest
, etc), for which we currently have targets in the Makefile (docker-build
,docker-push-master
,docker-create-push-manifests
, etc). Maintaining this non-trivial logic in the Makefile is cumbersome, and we could also benefit from making it reusable across different repos. This PR is a first step towards making these targets reusable across different repos, including -ext, the upcoming Snowflake image, etc.Changes
Add util script for building/pushing Docker images. The script follows a similar structure as the existing
bin/release-helper.sh
script we already have in place.🚧 more details following soon.. /cc @alexrashed
TODOs:
__version__
in__init__.py
filesTesting
The script has been tested in an upstream pipeline (snowflake repo). Still need to coordinate whether and how to integrate the script into the build process of this repo.