-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extract docker build / push make targets to helper script #10872
Conversation
c9ac2fa
to
fa855e6
Compare
Helper Script Tests16 tests 16 ✅ 0s ⏱️ Results for commit bf76448. ♻️ This comment has been updated with latest results. |
86dfeff
to
d0eae7b
Compare
00e4829
to
5b6fac2
Compare
5b6fac2
to
bf76448
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great set of changes!
The our build steps have really outgrown he makefile targets, so moving everything into a shell scripts makes it much more maintainable and easier to understand. The helper script is well structured and documented 👌 And neat approach to testing with bats and mocking the docker command 🧠
Approved!
Motivation
This PR supersedes #10276.
I created a new PR because the branch of #10276 is already used in a PoC project.
This PR extracts the complex Makefile targets to push our Docker images to a clean and tested bash script.
In addition this PR adds explicit tests, as well as a test pipeline for this script using
bats
and GitHub actions.Changes
bin/docker-helper.sh
:docker-build
docker-build-multiarch
docker-push-master
docker-create-push-manifests
docker-save-image
bats
tests totests/bin
.tests-bin.yaml
which executes these bats tests on PRs and onmaster
if the new helper is changed.TODO
docker-save-image
and its usage todocker-helper.sh
.latest
tag.