extract docker build / push make targets to helper script #10872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrashed
added
the
semver: minor
alexrashed
force-pushed
the
docker-helper-new
branch
from
c9ac2fa
to
fa855e6
Compare
Helper Script Tests16 tests 16 ✅ 0s ⏱️ Results for commit bf76448. ♻️ This comment has been updated with latest results. |
alexrashed
force-pushed
the
docker-helper-new
branch
2 times, most recently
from
86dfeff
to
d0eae7b
Compare
alexrashed
force-pushed
the
docker-helper-new
branch
6 times, most recently
from
00e4829
to
5b6fac2
Compare
alexrashed
force-pushed
the
docker-helper-new
branch
from
5b6fac2
to
bf76448
Compare
alexrashed
requested review from
thrau,
dfangl and
dominikschubert
as code owners
thrau
approved these changes
May 23, 2024
There was a problem hiding this comment.
Great set of changes!
The our build steps have really outgrown he makefile targets, so moving everything into a shell scripts makes it much more maintainable and easier to understand. The helper script is well structured and documented 👌 And neat approach to testing with bats and mocking the docker command 🧠
Approved!
HarshCasper
approved these changes
May 24, 2024
This was referenced May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR supersedes #10276.
I created a new PR because the branch of #10276 is already used in a PoC project.
This PR extracts the complex Makefile targets to push our Docker images to a clean and tested bash script.
In addition this PR adds explicit tests, as well as a test pipeline for this script using
batsand GitHub actions.Changes
bin/docker-helper.sh:docker-builddocker-build-multiarchdocker-push-masterdocker-create-push-manifestsdocker-save-imagebatstests totests/bin.tests-bin.yamlwhich executes these bats tests on PRs and onmasterif the new helper is changed.TODO
docker-save-imageand its usage todocker-helper.sh.latesttag.