New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Spark 2; Scala 2.10 deprecation #1628

Merged
merged 8 commits into from Sep 23, 2016

Conversation

Projects
None yet
2 participants
@pomadchin
Member

pomadchin commented Sep 9, 2016

Tests are passing, needs to be tested on a real cluster, fixes #1626

  • scala 2.10 deprecated
  • all libs update
  • Travis CI
  • Landsat EMR demo test
  • remove logging usage from serializable code (private Spark 2.0 Logging overload) dep hell related to scala landsat util (azavea/scala-landsat-util#6)
  • if we are going to support both Java 7 and Java 8, it is not possible to update typesafe config dep
  • noticed a bug / feature trying to update geotools
val actual = GeometryToSimpleFeature(multiPolygon, None, emptyList)
val expected = GeometryToSimpleFeature(multiPolygon, None, emptyList)

actual.equals(expected) 
// throws com.vividsolutions.jts.geom.TopologyException: 
// side location conflict [ (0.0, 3.0, NaN) ]
@pomadchin

This comment has been minimized.

Member

pomadchin commented Sep 9, 2016

It is still unclear for me, why we still need to exclude kryo (otherwise hbase tests would fail):

"de.javakaffee" % "kryo-serializers" % "0.38" exclude("com.esotericsoftware.kryo", "kryo") exclude("com.esotericsoftware", "kryo"),
"com.esotericsoftware" % "kryo-shaded" % "3.0.3"

@pomadchin pomadchin changed the title from Move to Spark 2 to Move to Spark 2 and Scala 2.10 deprecation Sep 12, 2016

@pomadchin pomadchin changed the title from Move to Spark 2 and Scala 2.10 deprecation to Move to Spark 2; Scala 2.10 deprecation Sep 12, 2016

@pomadchin

This comment has been minimized.

Member

pomadchin commented Sep 19, 2016

Should we deprecate java 7 as well?

@pomadchin pomadchin referenced this pull request Sep 20, 2016

Closed

More Joda serializers #1632

@lossyrob

This comment has been minimized.

Member

lossyrob commented Sep 23, 2016

@pomadchin re: java 7, I belive we decided yes, if there's changes that are required for that they can go in another PR.

@lossyrob lossyrob merged commit 0a377df into locationtech:master Sep 23, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lossyrob lossyrob added this to the 1.0 milestone Oct 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment