New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added library of land use classification color maps. #2073

Merged
merged 3 commits into from Mar 24, 2017

Conversation

Projects
None yet
2 participants
@metasim
Member

metasim commented Mar 15, 2017

No description provided.

metasim added some commits Mar 15, 2017

Initial cut at providing a library of `ColorMaps`, just like `ColorRa…
…mps`.

Signed-off-by: Simeon H.K. fitch <fitch@astraea.io>
Slipping in fix for a major source of compiler warnings.
Match wasn't catching `Error`. Both `Error` and `Failure` are the exclusive sub-types of `NoSuccess`, so changed match to that.

Signed-off-by: Simeon H.K. fitch <fitch@astraea.io>
@metasim

This comment has been minimized.

Member

metasim commented Mar 15, 2017

Travis error seems to have nothing to do with the actual build. Any way to re-trigger it?

@@ -0,0 +1,97 @@
/*
* Copyright 2016 Azavea

This comment has been minimized.

@lossyrob

lossyrob Mar 21, 2017

Member

Since you/your company is submitting this file, this should be copyright to you or your company.

defaultOptions
)
private val defaultOptions = ColorMap.Options(

This comment has been minimized.

@lossyrob

lossyrob Mar 21, 2017

Member

Why not just use ColorMap.Options.DEFAULT?

This comment has been minimized.

@metasim

metasim Mar 23, 2017

Member

Since the noDataColor was the same as the DEFAULT, I'm removing that. However, I think the classBoundaryType should be EXACT, because operationally, you want to know if you have a classification assignment that's not part of your class set (sign of an error, or something else).

This comment has been minimized.

@lossyrob

lossyrob Mar 24, 2017

Member

Fair point

@lossyrob lossyrob added this to the 1.1 milestone Mar 24, 2017

@lossyrob lossyrob merged commit 8f91098 into locationtech:master Mar 24, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
ip-validation
Details

@metasim metasim deleted the metasim:feature/color-map-library branch Mar 24, 2017

@metasim metasim restored the metasim:feature/color-map-library branch Mar 24, 2017

lossyrob added a commit to lossyrob/geotrellis that referenced this pull request Mar 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment