-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added library of land use classification color maps. #2073
Added library of land use classification color maps. #2073
Conversation
…mps`. Signed-off-by: Simeon H.K. fitch <fitch@astraea.io>
Match wasn't catching `Error`. Both `Error` and `Failure` are the exclusive sub-types of `NoSuccess`, so changed match to that. Signed-off-by: Simeon H.K. fitch <fitch@astraea.io>
Travis error seems to have nothing to do with the actual build. Any way to re-trigger it? |
@@ -0,0 +1,97 @@ | |||
/* | |||
* Copyright 2016 Azavea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you/your company is submitting this file, this should be copyright to you or your company.
defaultOptions | ||
) | ||
|
||
private val defaultOptions = ColorMap.Options( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just use ColorMap.Options.DEFAULT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the noDataColor
was the same as the DEFAULT
, I'm removing that. However, I think the classBoundaryType
should be EXACT
, because operationally, you want to know if you have a classification assignment that's not part of your class set (sign of an error, or something else).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point
No description provided.