Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OverlayNG Area Check heuristic for difference #1005

Merged

Conversation

dr-jts
Copy link
Contributor

@dr-jts dr-jts commented Oct 11, 2023

This change fixes the OverlayNG area check heuristic for the difference operation, to handle cases where the difference result has a very small area.

Fixes #951

@grimsa
Copy link
Contributor

grimsa commented Oct 12, 2023

@dr-jts I will test the fix by Monday and report here.

@grimsa
Copy link
Contributor

grimsa commented Oct 13, 2023

@dr-jts I can confirm that the fix works - we are no longer seeing the errors related to area check heuristic that we have seen before.

@dr-jts dr-jts merged commit ee68200 into locationtech:master Oct 17, 2023
2 checks passed
@dr-jts dr-jts deleted the improve-overlayng-difference-check branch October 17, 2023 19:55
@jodygarnett jodygarnett added this to the 1.20.0 milestone Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OverlayNG area check heuristic causing issues when snapping noder is used
3 participants