Improve CascadedPolygonUnion correctness with OverlapUnion #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Davis <mtnclimb@gmail.com>
Signed-off-by: Martin Davis <mtnclimb@gmail.com>
Signed-off-by: Martin Davis <mtnclimb@gmail.com>
strk
pushed a commit
to libgeos/geos
that referenced
this pull request
Sep 16, 2019
New approach to overlap handling, to deal with robustness issues while preserving more performance than the old GEOS fix. Add in fallback to buffer(0) when unary union fails, for more fault tolerance on hard cases. Apply some const correctness features when building geometries from vector<const *Geometry>, as many constructors must do (from @dbaston) locationtech/jts#470 locationtech/jts#429
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue in CascadedPolygonUnion where the union can move linework slightly and cause the combining step to create invalid geometry.
The overlapping union approach is refactored to the new class OverlapUnion, and a new test for changed line segments added to detect if a full union needs to be performed.
This should fix GEOS issue 837 while still providing good performance.