Add CascadedPolygonUnion bufferUnion #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Davis <mtnclimb@gmail.com>
|
Is there a test case that throws an exception with cascaded union but goes on to succeed with the buffer union? |
good point, I was thinking about this too. There's definitely quite a few large datasets which fail without this and pass with it. The trick is extracting a simple test case. I will work on this. It will be useful for GEOS too. In fact my hypothesis is that most union failures will actually work with buffer(0), so any of them would provide a test case. |
|
I am adding a test case for this in #471. No guarantee it has the same failing behaviour in GEOS, unfortunately. But hopefully it does. |
strk
pushed a commit
to libgeos/geos
that referenced
this pull request
Sep 16, 2019
New approach to overlap handling, to deal with robustness issues while preserving more performance than the old GEOS fix. Add in fallback to buffer(0) when unary union fails, for more fault tolerance on hard cases. Apply some const correctness features when building geometries from vector<const *Geometry>, as many constructors must do (from @dbaston) locationtech/jts#470 locationtech/jts#429
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves CascadedPolygonUnion by using a buffer(0) union if overlay union fails due to a topology error.
Signed-off-by: Martin Davis mtnclimb@gmail.com