Make Quadtree implementation threadsafe #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Queries and insertions to the quadtree can now work in multi-threaded environments.
|
This is a good improvement - thanks. Are you able to fill out the Eclipse Contributor Agreement? Otherwise, I will copy this into a new PR and merge it. |
|
Thanks, the Eclipse Contributor Agreement should be signed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
Quadtreeimplemention threadsafe. Queries and insertions to theQuadtreecan now work in multi-threaded environments.I've not contributed to this project before so it might be the case that the
Quadtreewas never meant to be threadsafe but for my use case; frequently updating and querying a singleQuadtreewith multiple threads, this was a significant performance bottleneck.