Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robinson projection (ESRI:54030) test failed #87

Closed
Yaqiang opened this issue Oct 16, 2022 · 2 comments
Closed

Robinson projection (ESRI:54030) test failed #87

Yaqiang opened this issue Oct 16, 2022 · 2 comments
Labels

Comments

@Yaqiang
Copy link
Contributor

Yaqiang commented Oct 16, 2022

Following test for Robinson projection failed.

    @Test
    public void testRobinson() {
        checkTransform("+proj=latlong +datum=WGS84", -30, 40, "+proj=robin +datum=WGS84", -2612095.95, 4276351.58, 2e-1);
        checkTransformFromWGS84("ESRI:54030", -30., 40., -2612095.954698802, 4276351.583838239);
        checkTransformToWGS84("ESRI:54030", -2612095.954698802, 4276351.583838239, -30., 40., 1E-4);
    }
@Yaqiang
Copy link
Contributor Author

Yaqiang commented Oct 16, 2022

I have solved the above bug and commit it to my proj4j forking repository (Yaqiang@42fa692) refering to the code of PROJ (https://github.com/OSGeo/PROJ/blob/master/src/projections/robin.cpp). But my last PR #86 was not reviewed and accepted, so I don't know to to commit a new PR now.

@pomadchin pomadchin added the bug label Oct 17, 2022
@Yaqiang
Copy link
Contributor Author

Yaqiang commented Nov 21, 2022

Solved by PR #86

@Yaqiang Yaqiang closed this as completed Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants