Allow the setting of a custom ToolManager and MapTracker #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sigend-off-by: Michael Sementsov <michael.sementsov@ibykus.de>
MSementsov-Ibk
force-pushed
the
settable-maptracker-and-toolmanager
branch
from
bf9e307
to
a0e44ae
Compare
fgdrf
reviewed
Oct 5, 2018
| @@ -976,9 +988,9 @@ public int getDPI() { | |||
| * @param activeMapTracker the tracker that managers | |||
| */ | |||
| public static void setActiveMapTracker( ActiveMapTracker activeMapTrackerToSet ) { | |||
| if (activeMapTracker != null ){ | |||
| /*if (activeMapTracker != null ){ | |||
There was a problem hiding this comment.
What's the reason behind to comment this block? It there a usecase to allow to re-set map-tracker?
fgdrf
reviewed
Oct 5, 2018
| * | ||
| * @param toolManager the new tool manager | ||
| */ | ||
| public static void setToolManager(IToolManager toolManager) { |
There was a problem hiding this comment.
Where is this Method called from and what is the reason to (re)set toolManager Singleton?
|
@fgdrf We use both of these methods inside our own products, where we have a custom ToolManager and ActiveMapTracker. There's no direct benefit for uDig, but having the option to set these would be nice. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Sementsov michael.sementsov@hotmail.de