Rename process to program name #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MJohnson459
reviewed
Feb 4, 2020
| @@ -1,2 +1,9 @@ | |||
| #!/usr/bin/env bash | |||
| ${${PROJECT_NAME}_VENV_DEVEL_DIR}/bin/python ${program_path} "$@" | |||
| #!${${PROJECT_NAME}_VENV_DEVEL_DIR}/bin/python | |||
There was a problem hiding this comment.
Nice. I wonder, did you test this with just this change (no setproctitle)? I was under the impression this might be enough but have never tried it.
There was a problem hiding this comment.
The interpreter name will still end up as part of sys.argv[0], so yeah, setproctitle (or similar) is still needed.
paulbovbel
force-pushed
the
rename-process
branch
from
e8befb8
to
7c9dd14
Compare
leftyfb
approved these changes
Feb 4, 2020
paulbovbel
force-pushed
the
rename-process
branch
from
7c9dd14
to
b12cd9a
Compare
paulbovbel
changed the title
|
Marking this WIP due to xenial packaging issue |
paulbovbel
force-pushed
the
rename-process
branch
from
b12cd9a
to
75ae12b
Compare
paulbovbel
changed the title
MJohnson459
approved these changes
Aug 5, 2021
leftyfb
approved these changes
Aug 5, 2021
garyservin
approved these changes
Aug 9, 2021
paulbovbel
force-pushed
the
rename-process
branch
from
592bf4d
to
0bca349
Compare
|
The |
paulbovbel
force-pushed
the
rename-process
branch
from
d3a9e6e
to
0bca349
Compare
paulbovbel
force-pushed
the
rename-process
branch
from
0bca349
to
2fecfba
Compare
paulbovbel
force-pushed
the
rename-process
branch
2 times, most recently
from
6ef1103
to
17b8531
Compare
paulbovbel
force-pushed
the
rename-process
branch
from
17b8531
to
d4d7567
Compare
|
Fixed by leveraging heredoc with exec rather than touching the shebang |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#51 works fine, but changing the process name seems to bork something about how the virtualenv is loaded (see test results).Replaced bash exec with python magic, this makes python process names very similar to native processes for monitoring purposes.Replaced shebang tweaking with bash and python magic.