Use types.clone to avoid Babel’s replaceWith cache. [closes #91]

lodash · Jul 15, 2016 · 84dbe7b · sidx1024 · Dec 14, 2021 · 84dbe7b
1 parent 432502d
commit 84dbe7b
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 2 deletions.
diff --git a/src/index.js b/src/index.js
@@ -62,7 +62,7 @@ export default function lodash({ types }) {
         if (isLodash && name == 'chain' && path.parentPath.isCallExpression()) {
           throw path.buildCodeFrameError(CHAIN_ERROR);
         }
-        path.replaceWith(identifier);
+        path.replaceWith(types.clone(identifier));
       });
     });
 
@@ -85,7 +85,7 @@ export default function lodash({ types }) {
           pkgStore.set(identifier.name, identifier);
 
           // Replace reference with its modular version.
-          parentPath.replaceWith(identifier);
+          parentPath.replaceWith(types.clone(identifier));
         }
         else if (isLodash) {
           const callee = getCallee(path);

diff --git a/test/fixtures/lodash-repeat-identifiers/actual.js b/test/fixtures/lodash-repeat-identifiers/actual.js
@@ -0,0 +1,5 @@
+import _, { noop } from 'lodash';
+
+const array = [_, _, _.noop, _.noop, noop, noop];
+
+noop(_, _, _.noop, _.noop, noop, noop);
diff --git a/test/fixtures/lodash-repeat-identifiers/expected.js b/test/fixtures/lodash-repeat-identifiers/expected.js
@@ -0,0 +1,11 @@
+'use strict';
+
+var _noop2 = require('lodash/noop');
+
+var _noop3 = _interopRequireDefault(_noop2);
+
+function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
+
+var array = [undefined, undefined, _noop3.default, _noop3.default, _noop3.default, _noop3.default];
+
+(0, _noop3.default)(_noop3.default.placeholder, _noop3.default.placeholder, _noop3.default, _noop3.default, _noop3.default, _noop3.default);