Only the last argument of a name in a CallExpression is transformed correctly.

[mthadley]

Starting with this:

import {noop, range} from 'lodash';

function myFunc() {}

myFunc(range, noop);
myFunc(noop, noop);
myFunc(range, noop, noop);
myFunc(range, noop, range, noop);
myFunc(range, noop, range, noop, range);

It will be transformed to this:

'use strict';

var _range2 = require('lodash/range');

var _range3 = _interopRequireDefault(_range2);

var _noop2 = require('lodash/noop');

var _noop3 = _interopRequireDefault(_noop2);

function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }

function myFunc() {}

myFunc(_range3.default, _noop3.default);
myFunc(_noop, _noop3.default);
myFunc(_range3.default, _noop, _noop3.default);
myFunc(_range, _noop, _range3.default, _noop3.default);
myFunc(_range, _noop, _range, _noop3.default, _range3.default);

I'm not sure where the issue is here on this one.

[jdalton]

It looks like it's an issue with identifiers repeated as different args.

[mthadley]

Also, looks like #90 might solve this?

[jdalton]

Ya, I'll hold off digging into this until that one is merged.

The issue still exists after the merge of #90.

[jridgewell]

Interesting. It's definitely finding and updating the references (noop gets changed to _noop), but Babel isn't finding each of them and converting it to the import reference _noop3.default. This is directly related to injecting a new import, and probably an upstream issue.

[jdalton]

Yep, I can confirm it's finding all the references in binding.referencePaths but it seems babel isn't recognizing the changes too all of the paths.

_.each(binding.referencePaths, path => {
  path.replaceWith(identifier);
})

\cc @hzoo

[jdalton]

Moving to babel/babylon#79 https://phabricator.babeljs.io/T7493.

[jdalton]

Circling back...

The issue appears to be a Babel cache of some kind. We memoize and reuse our identifier objects. However, as this issue shows, it can lead to path.replaceWith ignoring repeat identifier replacements. The solution at the moment looks like shallow cloning the identifier object to avoid the Babel cache.

[jridgewell]

Nice find! types provides a #clone for nodes, instead of using lodash's.

[jdalton]

🙌

I'm not sure all the places that may need the clone, but we'll start out with replaceWith calls and add as needed.