This repository has been archived by the owner on Sep 16, 2023. It is now read-only.
Babel 7 compatibility (Fixes #193) #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Babel no longer does this internally as of babel/babel#6343. This commit implements the same traversal as part of this plugin, using the same code that was removed from Babel with some trivial modifications.
file.addImport is deprecated by Babel and attempting to use it will throw.
|
|
jscinoz
changed the title
|
Wow, thank you @jscinoz! |
|
That was quick! Any chances we can get an npm release with a |
|
@tomchentw It will most likely happen |
|
@jdalton Any chance you can cut a release for this? Tested locally it resolved the issue. |
Closed
|
v3.3.0 has been published 🎉 |
|
which broke like this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #193
Fixes compatibility with Babel 7, by using babel-helper-module-import's addDefault (instead of file.addImport, which is deprecated in Babel 7), and traversing the AST ourselves to find module imports, as Babel no longer does this for us.
Tests pass, and compatibility appears to be maintained with Babel 6.26.0, but I have not tested this extensively.