Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for logback 1.2 #970

Merged
merged 1 commit into from
Jun 17, 2023
Merged

Drop support for logback 1.2 #970

merged 1 commit into from
Jun 17, 2023

Conversation

philsttr
Copy link
Collaborator

@philsttr philsttr commented Jun 17, 2023

Drop support for logback 1.2 in preparation for upcoming support for keyValue pairs in slf4j 2 and logback 1.3 in #954

Drop support for logback 1.2 in preparation for upcoming support for keyValue pairs in slf4j 2 and logback 1.3
@philsttr philsttr added type/enhancement warn/behavior-change Breaking change of publicly advertised behavior labels Jun 17, 2023
@codecov
Copy link

codecov bot commented Jun 17, 2023

Codecov Report

Merging #970 (ea18315) into main (639c28f) will increase coverage by 0.13%.
The diff coverage is 88.88%.

@@             Coverage Diff              @@
##               main     #970      +/-   ##
============================================
+ Coverage     71.92%   72.05%   +0.13%     
+ Complexity     1356     1353       -3     
============================================
  Files           173      173              
  Lines          5011     4999      -12     
  Branches        519      517       -2     
============================================
- Hits           3604     3602       -2     
+ Misses         1153     1148       -5     
+ Partials        254      249       -5     
Impacted Files Coverage Δ
...n/java/net/logstash/logback/util/LogbackUtils.java 75.00% <ø> (+10.29%) ⬆️
...ogback/composite/AbstractSequenceJsonProvider.java 90.90% <83.33%> (+3.95%) ⬆️
...nt/LoggingEventFormattedTimestampJsonProvider.java 100.00% <100.00%> (+50.00%) ⬆️
...site/loggingevent/LogstashMarkersJsonProvider.java 94.44% <100.00%> (+9.44%) ⬆️
...gback/composite/loggingevent/TagsJsonProvider.java 96.29% <100.00%> (+6.64%) ⬆️

@philsttr philsttr merged commit af9f826 into main Jun 17, 2023
@philsttr philsttr deleted the drop_logback_12 branch June 17, 2023 14:03
@analytically
Copy link

This is quite some breaking change.

@carl-parrish
Copy link

upgrading from 7.3 to 7.4 just destroyed all my unitTests so far this is the only thing I can think that would have that kind of impact. I didn't write the original code any suggestions on what I should look for to see if I had logbook 1.2 dependencies in my code? Any docs on migration?

@philsttr
Copy link
Collaborator Author

philsttr commented Aug 31, 2023

Hi @carl-parrish, Check the logback news for details on changes in logback 1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement warn/behavior-change Breaking change of publicly advertised behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants