Set consensus timeout conservatively for happy-path integration tests #492
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found that the first nomos-node sometimes invokes local_timeout, because the consensus timeout was set tightly (10s for 10 nodes), even though it takes 1+ secs for each nomos-node to be started:
nomos-node/nomos-services/consensus/src/network/adapters/libp2p.rs
Line 237 in d479721
For happy tests, we need to see the consensus timeout conservatively, so that timeout doesn't happen at the startup phase.
This will solve the following CI failure in the master branch and #445 (comment).
Please note that I haven't changed the test timeout 20s:
nomos-node/tests/src/tests/happy.rs
Line 18 in 7fcfe89