Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set consensus timeout conservatively for happy-path integration tests #492

Merged
merged 5 commits into from
Oct 30, 2023

Conversation

youngjoon-lee
Copy link
Contributor

@youngjoon-lee youngjoon-lee commented Oct 30, 2023

I've found that the first nomos-node sometimes invokes local_timeout, because the consensus timeout was set tightly (10s for 10 nodes), even though it takes 1+ secs for each nomos-node to be started:

tokio::time::sleep(std::time::Duration::from_secs(1)).await;

For happy tests, we need to see the consensus timeout conservatively, so that timeout doesn't happen at the startup phase.

This will solve the following CI failure in the master branch and #445 (comment).

timed out waiting for nodes to reach view 20

Please note that I haven't changed the test timeout 20s:

let timeout = std::time::Duration::from_secs(20);

@youngjoon-lee youngjoon-lee changed the title test: set consensus timeout for integration tests conservatively test: set consensus timeout conservatively for happy-path integration tests Oct 30, 2023
@youngjoon-lee youngjoon-lee marked this pull request as ready for review October 30, 2023 09:09
@danielSanchezQ danielSanchezQ changed the title test: set consensus timeout conservatively for happy-path integration tests Test: set consensus timeout conservatively for happy-path integration tests Oct 30, 2023
@youngjoon-lee youngjoon-lee changed the title Test: set consensus timeout conservatively for happy-path integration tests Set consensus timeout conservatively for happy-path integration tests Oct 30, 2023
tests/src/lib.rs Outdated Show resolved Hide resolved
@youngjoon-lee youngjoon-lee merged commit 5e520ae into master Oct 30, 2023
7 checks passed
@youngjoon-lee youngjoon-lee deleted the test-consensus-timeout branch October 30, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants