Increase the 20-view timeout of happy integration tests #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngjoon-lee
changed the title
zeegomo
approved these changes
Oct 31, 2023
danielSanchezQ
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although #492 prevents occasional consensus timeouts from happy integration tests, the test sometimes fails with the same error:
timed out waiting for nodes to reach view 20, only in the codecov CI.Assuming that tests are slower in the codecov CI, I increased the 20-view timeout of happy integration tests.
(We could set the timeout differently by reading the codecov-related env vars, but I didn't want to make things complicated now.)
Even if it's not the reason of failure (even if the test still fails due to consensus timeout), it's fine because the test will fail anyway at the last stage that checks whether the consensus timeout has never happened.