Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: support redis cluster and additional options for cache #5598

Closed
alekitto opened this issue Mar 30, 2024 · 1 comment · Fixed by #5619
Closed

feature request: support redis cluster and additional options for cache #5598

alekitto opened this issue Mar 30, 2024 · 1 comment · Fixed by #5619
Assignees
Labels
feature-request Something cool or not cool

Comments

@alekitto
Copy link
Contributor

What problem did you meet?

Redis cache configuration is quite limited:

  • redis cluster cannot be used
  • tls options (such as using self-signed certs, provide custom CA, etc) cannot be set in REDIS_URL env variables

Describe what you'd like Logto to have

REDIS_URL environment variable should be parsed to accept multiple hosts and redis_cluster query parameter to support connection to redis cluster. Ex:

redis:?host=127.0.0.1&host=192.168.2.3&redis_cluster=1

should establish a connection to a redis cluster with root nodes 127.0.0.1 and 192.168.2.3.

At the same time reject_unauthorized=0 could be passed to accept self-signed certificates and cert, key, certroot parameters could be used to specify the files to read to connect via mTLS or with a custom CA.

I can provide a PR to support these options in case you're intrested in implementing this.

@wangsijie wangsijie self-assigned this Mar 31, 2024
@wangsijie wangsijie added the feature-request Something cool or not cool label Mar 31, 2024
@wangsijie
Copy link
Contributor

Thanks for the suggestion. We're always open to contributions. If you or anyone else is interested in working on this, we'd be happy to review a pull request. Thanks again for your input!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Something cool or not cool
Development

Successfully merging a pull request may close this issue.

2 participants