Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use uWebSocket #31

Merged
merged 4 commits into from
May 3, 2017
Merged

Use uWebSocket #31

merged 4 commits into from
May 3, 2017

Conversation

sairus2k
Copy link
Contributor

No description provided.

Replace ws with uws, fixed tests
Fix getting client remote address
@ai
Copy link
Member

ai commented Apr 28, 2017

@sairus2k note, that you still have problem in Travis CI

@sairus2k
Copy link
Contributor Author

sairus2k commented Apr 28, 2017 via email

@ai
Copy link
Member

ai commented Apr 28, 2017

OK, I will try to look on my machine. Maybe it is related to concurrency. Or to yarn lock?

Check for client remote address
Try to connect client to ip address not to hostname
@sairus2k sairus2k closed this Apr 30, 2017
@sairus2k sairus2k reopened this Apr 30, 2017
@sairus2k
Copy link
Contributor Author

@ai Probably, localhost on Travic-CI resolves to ipv6 address
This is the issue:
https://github.com/uWebSockets/uWebSockets/issues/342
Then it fails only for node version 6.10.2 with another error. I restarted build using close and reopen pull request and all tests passed.

@ai
Copy link
Member

ai commented Apr 30, 2017

Great invastigation. Sorry, I stock on Autoprefixer 7 release :(

@ai ai merged commit 96b0413 into logux:master May 3, 2017
@ai
Copy link
Member

ai commented May 3, 2017

Thanks. Whatis your Twitter and VK accounts for announce?

@sairus2k
Copy link
Contributor Author

sairus2k commented May 3, 2017

https://vk.com/sairus2k

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants