Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.NET Core libraries should reference System.Runtime instead of mscorlib #13

Closed
osman-turan opened this issue Mar 7, 2019 · 0 comments
Closed

.NET Core libraries should reference System.Runtime instead of mscorlib #13

osman-turan opened this issue Mar 7, 2019 · 0 comments
Assignees
@osman-turan
Labels
bug Something isn't working

Comments

@osman-turan
Copy link
Collaborator

Dynamically generated assemblies reference System.Private.CoreLib assembly first. System.Private.CoreLib public key token is same as mscorlib. Since, .NET Core is fundamentally different from .NET Framework (.NET Core supports side-by-side runtime), we shouldn't reference mscorlib first. Instead, we should reference System.Runtime assembly which we should extract at its metadata at runtime. Also, we should map all mscorlib and System.Private.CoreLib references to System.Runtime.
@osman-turan osman-turan added the bug Something isn't working label Mar 7, 2019
@osman-turan osman-turan self-assigned this Mar 7, 2019
osman-turan added a commit that referenced this issue Mar 7, 2019
@osman-turan
Fix core library reference
b05d4c3 
This commit maps `System.Private.CoreLib` and `mscorlib` to `System.Runtime`.

Fixes: #13
This was referenced Mar 7, 2019
Merged
Closed
@Karolis2011 Karolis2011 mentioned this issue Apr 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@osman-turan osman-turan

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@osman-turan