Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(with patch) #132

Closed
mf-RDP opened this issue Dec 6, 2020 · 1 comment
Closed

(with patch) #132

mf-RDP opened this issue Dec 6, 2020 · 1 comment

Comments

@mf-RDP
Copy link

mf-RDP commented Dec 6, 2020

Hi,

attached a patch for a little issue in AssemblyMetadata.cs ("HACK: [vermorel] 2019-07-25.").

It will attach a ref to "netstandard" and make sure the ref to the assemblyname "system.private.corelib" is as per loaded in application current domain.

I noticed problems when AOTing with Mono (system.private.corelib not found) and ILSpy couldn't resolve these references either. With this patch, problems are gone.

I cannot say 100% sure if it will work for all NET versions, tested with netcore31, net50, mono. All ok-

0001-patch-for-reference-assemblies-netstandard-unresolve.zip

Best regards,
S.

vermorel added a commit that referenced this issue Dec 7, 2020
Kudos to @mf-RDP for subimitting the patch.

#132
@vermorel
Copy link
Member

vermorel commented Dec 7, 2020

Thanks for the patch. It's preferable to use the pull requests, it's easier to edit, and it's also easier to assign proper attribution.

@vermorel vermorel closed this as completed Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants