Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete underscores from submodule filenames #63

Closed
Soveu opened this issue May 17, 2020 · 3 comments
Closed

Delete underscores from submodule filenames #63

Soveu opened this issue May 17, 2020 · 3 comments

Comments

@Soveu
Copy link
Contributor

Soveu commented May 17, 2020

They are just annoying to type everytime

@Soveu
Copy link
Contributor Author

Soveu commented May 17, 2020

Or maybe we should re-organize code a little bit
Now src/lib.rs mostly contains code related to x86/x64 arch, I suggest to move it into src/x86_x64/mod.rs.
It will make lib.rs cleaner and ready for other architectures

@Lokathor
Copy link
Owner

the underscores have to be there or it conflicts with the naming of the type, since module paths and type paths "live in the same namespace" in the eyes of rust.

@Lokathor
Copy link
Owner

As to a total re-organization, I'm not against the general idea, and I agree that once ARM intrinsics are ready to be added we might have to re-think things, but I've really never liked either mod.rs or foo.rs being next to the foo/ folder. I'm pretty big on this new inline module based style that I was shown a few months ago, since it lets you avoid both.

@Lokathor Lokathor closed this as completed Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants