Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[multi-device] Ensure the latest contact signed prekey is used #495

Merged
merged 3 commits into from
Sep 16, 2019

Conversation

sachaaaaa
Copy link

This PR fixes the following bug:

  • the secondary device sends a first pairing request with a signed prekey id = 1.
  • after timeout, the secondary device is allowed to re-send a request. Signed prekeys are wiped and a new signed prekey with id 2 is sent.
  • the secondary device accepts but uses the signed prekey with id 1.

Also, improves cleaning up bundles when requests are not accepted.

Removed removeAllPreKeys in resetRegistration since that already happens inside the registerSingleDevice function.

Copy link

@Mikunj Mikunj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor question

js/views/app_view.js Show resolved Hide resolved
Copy link

@Mikunj Mikunj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@sachaaaaa sachaaaaa merged commit d17f866 into oxen-io:multi-device Sep 16, 2019
@sachaaaaa sachaaaaa deleted the fix_unknown_signedkey branch September 16, 2019 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants