Add server #557
Merged
Add server #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 9, 2019 14:06
…in the factory. Fix up the areas this affects
msgmaxim
approved these changes
Oct 10, 2019
|
Could we give the buttons some margin, so the error message is not directly on top of them? |
neuroscr
approved these changes
Oct 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new button to main menu for connecting to a new public chat server
Currently we just only attempt to connect to the channel with ID 1 (this logic will probably do something weird if this channel doesn't exist/work but the server is functional)
Potential plans for the future are having another modal after connecting to the server allowing users to select the channels they want to join
Leaving a public chat does work but I think we are not clearing all server metadata at the moment (tokens) which may or may not be an issue in the future
Fixes #554