Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server #557

Merged
merged 4 commits into from Oct 22, 2019

Conversation

@BeaudanBrown
Copy link
Collaborator

BeaudanBrown commented Oct 9, 2019

Add new button to main menu for connecting to a new public chat server
Currently we just only attempt to connect to the channel with ID 1 (this logic will probably do something weird if this channel doesn't exist/work but the server is functional)
Potential plans for the future are having another modal after connecting to the server allowing users to select the channels they want to join
Leaving a public chat does work but I think we are not clearing all server metadata at the moment (tokens) which may or may not be an issue in the future
Fixes #554

image
image
image

@BeaudanBrown BeaudanBrown requested review from neuroscr, msgmaxim and Mikunj Oct 9, 2019
@BeaudanBrown BeaudanBrown force-pushed the BeaudanBrown:add-server branch from 5160b36 to 363cd81 Oct 9, 2019
@msgmaxim

This comment has been minimized.

Copy link
Collaborator

msgmaxim commented Oct 10, 2019

Could we give the buttons some margin, so the error message is not directly on top of them?

@BeaudanBrown BeaudanBrown merged commit ac80ef0 into loki-project:clearnet Oct 22, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@BeaudanBrown BeaudanBrown deleted the BeaudanBrown:add-server branch Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.