Fix version printing in info message #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If major/minor are uint8_t then printing them tries to print characters rather than numbers. Changing them to uint16_t seems the easiest fix (and agrees with the type we use for storing version parts in proofs).
jagerman
force-pushed
the
fix-version-printing
branch
from
6a9285c
to
4b8c62b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If major/minor are uint8_t then printing them tries to print characters
rather than numbers. Changing them to uint16_t seems the easiest fix
(and agrees with the type we use for storing version parts in proofs).