Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strict Mode compatibility #145

Closed
gempir opened this issue Dec 30, 2020 · 2 comments
Closed

Strict Mode compatibility #145

gempir opened this issue Dec 30, 2020 · 2 comments
Labels
enhancement

Comments

@gempir
Copy link

gempir commented Dec 30, 2020

It would be great to make this library compatible with react strict mode.

https://reactjs.org/docs/strict-mode.html

Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of LazyLoad which is inside StrictMode. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here: https://reactjs.org/link/strict-mode-find-node
@loktar00
Copy link
Owner

Working on this currently, adding the enhancement label.

@loktar00
Copy link
Owner

This should now work with 4.0, fixed in #155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@loktar00 @gempir