-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove spaces in extras_require
#49
Comments
Apparently, using spaces in dictionary keys is absolutely valid, as discussed in https://stackoverflow.com/questions/13474957/spaces-in-python-dictionary-keys. But I can see your point that it becomes inconvenient in this case. On the other hand, the |
I wasn't referring to spaces in dictionary keys in general, I was specifically referring to extra requires. Also I think there is now a wheel for itk so I think It can be pip installed. |
You're right, that's amazing. Thank you for pointing this out to me! https://blog.kitware.com/itk-is-on-pypi-pip-install-itk-is-here/ Did you already tried if the |
Ok given that people probably were not using that extra (and that It didn't work until recently) what do you think about renaming it to |
I would go with |
Right now the
extras_require
is:which contains a space in the key, something I have never seen before. This causes problems when trying to pip install. Perhaps there is a way to escape, but this seems non intuitive:
I suggest offering a string without a space.
The text was updated successfully, but these errors were encountered: