Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] JAR renaming #2

Closed
Krutoy242 opened this issue Mar 22, 2022 · 2 comments
Closed

[Feature Request] JAR renaming #2

Krutoy242 opened this issue Mar 22, 2022 · 2 comments

Comments

@Krutoy242
Copy link

Rare mods require strict .jar file name, like ThaumTweaks:

This makes unable to use Bansoukou with ThaumTweaks together.

I was planned to use Bansoukou to manually fix issue with Web and researches.

Request

Please add feature to rename .jar file to custom name or skip renaming at all.

Bansoukou already renaming file to {FILENAME}-patched.jar. If i can skip renaming, and file would be modified in place, it would fix my issue with ThaumTweaks.

Also, it would be nice if I can chose file name, for example putting file __filename.txt in bansoukou/ folder, that would not be added to .jar but it contents would be used for renaming.

For example, if i want to place DankNull mod on buttom of mods/ folder i could make file ./DankNull-1.12.2-1.7.101/__filename.txt with content:

zz_DankNull-1.12.2-1.7.101.jar
@Rongmario
Copy link
Member

I replied over at the issue thread you opened at ThaumTweaks' repository.

I will not be fixing this because it is physically impossible, the reason why I rename duplicate the jar and append a -patched after the filename is to circumvent CurseForge's client from deleting the patched jar when the game launches.

I will however think about making the patched jar's name configurable.

Krutoy242 added a commit to Krutoy242/Enigmatica2Expert-Extended that referenced this issue Mar 22, 2022
- Remove [Web] and [String] from requirment of **Hedge Alchemy**
- Less Vis Crystals for Mettalurgy researches

This fixes was being unable to add with Bansoukou. They will be left in git, but without actual changes in modpack.

Changes need to be enabled when any of this issues would be resolved:
LoliKingdom/Thaumic-Speedup#3
GrigLog/ThaumTweaks#24
LoliKingdom/Bansoukou#2
@Rongmario
Copy link
Member

Fixed in v5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants