Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If subsystem is not enabled on startup, it is never initialized #17

Closed
i-am-gizm0 opened this issue Dec 30, 2019 · 0 comments
Closed

If subsystem is not enabled on startup, it is never initialized #17

i-am-gizm0 opened this issue Dec 30, 2019 · 0 comments
Assignees
@i-am-gizm0
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@i-am-gizm0
Copy link
Member

Eventually, when a subsystem is being enabled for the first time, it needs to have its init() method called. This never happens so it will throw SubsystemUninitializedExceptions everywhere
@i-am-gizm0 i-am-gizm0 added bug Something isn't working help wanted Extra attention is needed labels Dec 30, 2019
i-am-gizm0 added a commit that referenced this issue Dec 30, 2019
@i-am-gizm0
Lots of big changes (and lots of small ones)
c5d6091 
For the most part, this has been tested to work
# build.gradle
- Starting to try to simulate within WPILib
# frc.robot.Robot
- General maintenence
- SubsystemManager is now actually implemented and enables/disables subsystems
- Created a new method to send the normal status (which happens a lot)
- Manipulator control
 - Switches what is active based on the direction of control (See Controls.md)
# org.longmetal.Arduino
- Documentation
- New PROBLEM Status. Needs to be added to UsefulRSL.ino (in master)
# org.longmetal.Constants
- Documentation for unclear values
- Values required for new things (manipulator stuff)
# org.longmetal.Shooter
- Can now do what it's supposed to
 - Modifiers can be applied regardless of shooting speed
- Angle will work now
# org.longmetal.SubsystemManager
- SendableChooser s actually work now (as long as you call the `checkSendables()` method occasionally)
- Subsystems enable/disable cleanly (except for #17 )
# org.longmetal.util.Math
- Documentation
i-am-gizm0 added a commit that referenced this issue Dec 31, 2019
@i-am-gizm0
Fix #17
b902461 
If a subsystem was not initialized, the first time we try to use it, it will throw a SubsystemUninitializedException and we can catch that and initialize the subsystem
@i-am-gizm0 i-am-gizm0 self-assigned this Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@i-am-gizm0 i-am-gizm0

Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@i-am-gizm0