Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project from team repo #5

Merged
merged 19 commits into from
Oct 18, 2023

Commits on Oct 16, 2023

  1. Update Patient constructor arguments

    Currently, Patient class is taking in Department and Record as input
    
    Department and Record are to be created when Patient is created, thus it
    shouldnt be an input
    
    Update Patient constructor to remove AssignedDepartment and Record
    parameters, also initialiazed them with default values
    AaronJT1 committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    20b0781 View commit details
    Browse the repository at this point in the history
  2. Update Record.java to initialise with default values

    Currently, the instantiation of Record class does not initialise default
    values for other fields.
    
    This means that if a particular program wants to get its attribute
    value, it could lead to null value.
    
    Update Record.java to include 3 default initialization values for its
    fields
    AaronJT1 committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    6d01c19 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a47d6c3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8a6510d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9df51a2 View commit details
    Browse the repository at this point in the history
  6. Update SampleDataUtil.java to use new Patient class

    Currently, the sample patients are using outdated fields.
    
    It is important to update the patients to use the new fields.
    
    Add the Gender, IcNumber and Birthday fields to sample Patients
    AaronJT1 committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    b6e2c2e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d63a1c3 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    3dd88ff View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    17c2e69 View commit details
    Browse the repository at this point in the history
  10. Update EditCommand.java, EditCommandParser.java, and ParserUtil.java.

    Edit EditCommand.java, EditCommandParser.java, and ParserUtil.java so that we can edit the patient information and its record.
    longnguyentan committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    b127dd9 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. Merge pull request #102 from AaronJT1/branch-update-patient-fields

    Branch update patient fields
    wujy28 committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    294222e View commit details
    Browse the repository at this point in the history
  2. Merge pull request #103 from longnguyentan/branch-EditCommand

    Update EditCommand.java, EditCommandParser.java, and ParserUtil.java
    AaronJT1 committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    839b570 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5b575f6 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #104 from AaronJT1/branch-fixing-patient-dependency

    Update AddCommandParser to integrate ParserUtil
    RiyaMehta2211 committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    f85622f View commit details
    Browse the repository at this point in the history
  5. Fix inconsistencies in EditCommand and EditCommandParser

    Currently, the EditCommand and EditCommandParser classes are
    inconsistent in that they contain methods that process
    patient attributes that are not parameters into the Edit
    command, or certain parts lack the processing of important
    attributes.
    
    Fixing this issue will prevent further bugs and lead to
    neater code.
    
    Let's,
    * Add and remove attributes in the two classes for
    consistency
    * Make sure that important attributes are mentioned in
    parts that were previously lacking them
    wujy28 committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    8233415 View commit details
    Browse the repository at this point in the history
  6. Fix StackOverflow bug involving PatientBuilder and RecordBuilder

    There is an issue where after PatientBuilder() is called,
    it will call RecordBuilder(), which in turn calls
    PatientBuilder() again, causing a StackOverflow error.
    
    We need to fix this to get our test cases to pass.
    
    Let's
    * Add a new constructor to RecordBuilder that takes in
    a PatientBuilder to initialize its patient, instead
    of calling PatientBuilder again
    * Add new attributes to TypicalPatients
    
    Note that not all of the fields in Typical Patients are
    updated! AMY and BOB still need to be updated, which
    involves adding new attributes into CommandTestUtilgit add --all
    wujy28 committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    5363de7 View commit details
    Browse the repository at this point in the history
  7. Add new attributes to some console messages

    The existing console messages do not display the
    new attributes, confusing the user as to what
    attributes are available.
    
    Adding them to the messages allow them to view
    all the patient's attributes even without the
    updated GUI.
    
    Let's update the Add command and patient messages.
    wujy28 committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    9e0710c View commit details
    Browse the repository at this point in the history
  8. Fix CheckStyle Issues

    wujy28 committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    fe15562 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Merge pull request #108 from wujy28/branch-Edit-Command

    Fix Issues in Edit Command
    longnguyentan committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    1da5292 View commit details
    Browse the repository at this point in the history