Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terrain help doesn't distinguish between Cultivate and Irrigate #721

Closed
lmoureaux opened this issue Nov 15, 2021 · 0 comments · Fixed by #765
Closed

Terrain help doesn't distinguish between Cultivate and Irrigate #721

lmoureaux opened this issue Nov 15, 2021 · 0 comments · Fixed by #765
Labels
bug Something isn't working documentation Improvements or additions to documentation
Milestone

Comments

@lmoureaux
Copy link
Contributor

Describe the bug

The two are now separate, but the help keeps merging them.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Help > Terrain > Swamp
  2. Look at the help for Irrig. Reslt
  3. Swamp can't be irrigated, only cultivated

Expected behavior

It shows "Cultivate result" or something similar.

Screenshots

image

Platform and version (please complete the following information):

  • OS: ?, probably any
  • Freeciv21 version: 3.0-alpha9
  • Ruleset/Longturn game (if applicable): classic or Sim30

Additional context

if (pterrain->irrigation_result != pterrain
&& pterrain->irrigation_result != T_NONE
&& pterrain->cultivate_time != 0
&& action_id_univs_not_blocking(ACTION_CULTIVATE, NULL, &for_terr)) {
char buffer[1024];
fc_snprintf(buffer, sizeof(buffer),
PL_("%d turn", "%d turns", pterrain->cultivate_time),
pterrain->cultivate_time);
str = N_("Irrig. Rslt/Time:");

@lmoureaux lmoureaux added bug Something isn't working documentation Improvements or additions to documentation labels Nov 15, 2021
@lmoureaux lmoureaux added this to the v3.0-beta.1 milestone Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant