Change the Nations button blink to a gentle notification emblem #1698
Conversation
Also cleaned up the SVG to be easier to edit.
This minimizes the annoyance while still hinting that something in the tab is active. Closes longturn#1676.
|
The overall change is more appealing and does match the messages icon. however i think the change is missing a refresh. after canceling two meetings... i would expect to see base flag. |
|
Opened two meetings, restarted the client, closed them: |
|
It looks like an artifact of the old image with the dot on it. Is there a way to clear the old icon as part of the refresh? |
|
Another point of note, I left one savegame with the icon "bad" and then opened another savegame and the icon did not revert to "no meetings" mode, it was still in a bad state. |
Would you have the save? |
|
This is the first save that I have that starts with two meetings at load. This is the second one I did in my last comment that started with the "artifact" |
|
Ok something is up with my local. I was looking at icon files for the PR on allies button and noticed this So somehow my |
|
The resize of |
|
Can't see anything in the svg that would cause this issue. Is the file partially merged? |
Qt 5.15.3 has problems rendering the new version. See longturn#1698. See QTBUG-92184.
|
Changes to |
|
(For the record, this is a QtSvg bug) |
I looked at the commit log between your QtSvg and mine (which has the bug fixed). There were like 3 changes, and only one commit message looked relevant. |
|
I'm going to document the change in another PR, so merging this now. |
Qt 5.15.3 has problems rendering the new version. See #1698. See QTBUG-92184.
This minimizes the annoyance while still hinting that something in the tab is active. The notification icon uses the same design as in the Messages button.
Closes #1676.
Backport candidate.